Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip code generation for repositories that were pulled in as includes #1084

Closed
adamreeve opened this issue Jun 25, 2024 · 1 comment · Fixed by #1086
Closed

Skip code generation for repositories that were pulled in as includes #1084

adamreeve opened this issue Jun 25, 2024 · 1 comment · Fixed by #1086

Comments

@adamreeve
Copy link
Contributor

adamreeve commented Jun 25, 2024

Continuing the discussion from #1078 (comment)

Currently the GirTool generate command accepts a list of input repository files to generate code for. Any includes in these files are resolved and added to the list of output repositories by the RepositoriesDependencyResolver class. This is needed for generating code for interacting with dependencies, but sometimes users won't want to generate code for all dependencies but rather use them via package references, such as when using GirCore.GLib-2.0 for example.

I'd like to change the GirTool behaviour so that these includes that aren't from repositories explicitly listed in the input argument don't get code generated. They would still need to be loaded and resolved though.

@badcel
Copy link
Member

badcel commented Jun 25, 2024

This sounds like a good first step into the right direction for me. Fell free to work on this item 🚀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants