Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable capture and custom content handling of empty search results and search error #192

Open
mgrauer opened this issue Oct 18, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mgrauer
Copy link

mgrauer commented Oct 18, 2019

Let's say I have a custom search method, sometimes the search will return nothing and sometimes the search will be in error (say it is invalid according to my custom search method DSL).

I would like to

(1) be able to display custom content when there are no search results

and

(2) be able to display custom error content when my custom search handler returns an error (also which http error code should be sent back here, and can my custom search handler even control that?).

Apologies for issue scope sprawl.

@subdavis
Copy link
Contributor

@mgrauer this looks like something you're still going to want. Is that correct?

@subdavis subdavis added the enhancement New feature or request label Mar 13, 2020
@mgrauer
Copy link
Author

mgrauer commented Mar 13, 2020

yes please

@subdavis subdavis added the good first issue Good for newcomers label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants