Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH Keys add button does not work #1226

Closed
spirritus opened this issue Apr 10, 2017 · 6 comments
Closed

SSH Keys add button does not work #1226

spirritus opened this issue Apr 10, 2017 · 6 comments
Labels
🐱 Defect Status-Done

Comments

@spirritus
Copy link

Hi,

adding ssh-keys via command line works fine, however the button on the webinterface does not seem to do anything.
@spirritus spirritus changed the title SSH Keys add buttond oes not work SSH Keys add button does not work Apr 10, 2017
@martinspielmann martinspielmann mentioned this issue May 21, 2017
Merged
@flaix
Copy link
Member

flaix commented Nov 16, 2019

Closing this as fixed with PR #1239, as no further feedback available. Assuming input error.

@flaix flaix closed this as completed Nov 16, 2019
@madukan
Copy link

madukan commented Jul 23, 2022

This issue still persist. Trying to click add after setting a ssh public key at the Gitblit profile page doesn't go anywhere. No error in the Javascript console either. I'm running through Docker, no errors seen in the Docker logs either.

@flaix
Copy link
Member

flaix commented Jul 28, 2022

Well, what do you see in the Docker logs? Because I just tried and it works as expected. I can add a key and after clicking add, I see the key in the list of keys.

2022-07-28 19:01:15 [INFO ] loading ssh keystore for florian
2022-07-28 19:02:38 [INFO ] loading ssh keystore for florian

@madukan
Copy link

madukan commented Jul 28, 2022 •
edited
Loading

Nothing useful in there.

2022-07-28 20:24:09 [INFO ] 23 repository models loaded for muds in 15 msecs
2022-07-28 20:24:09 [INFO ] loading ssh keystore for ****

Network call seem to pass to the container from the browser though and receive a HTTP 200.

@flaix
Copy link
Member

flaix commented Jul 29, 2022

But adding the SSH key via the command line works, as in the original ticket description?
Or is it that it doesn't work at all like in #1415
I cannot reproduce this.

@flaix flaix mentioned this issue Oct 26, 2022
Closed
flaix pushed a commit to flaix/gitblit that referenced this issue Nov 1, 2022
@flaix
Add feedback to SSH Key Form. gitblit-org#1226
0e344ae 
if key is empty of can not be parsed, form did provide any feedback to
user before
flaix added a commit to flaix/gitblit that referenced this issue Nov 1, 2022
@flaix
Merge branch 'sshkey_form_feedback' into master
2f122c9 
This brings back in a change that was implemented in a pull request
from 2017, but got lost in the chaos of multiple pull requests from
intermingling branches.

This does not only provide feedback when a SSH key cannot be parsed,
but it also does so in a way that the warning goes away when a correct
key is added. Admittedly, I have no idea how to properly do this with
a Wicket FeedbackMessage, all I could find on Google was highly
complicated.

Not only does this bring back (or really in) the fix for issue gitblit-org#1226,
but it also fixes gitblit-org#984.
@flaix
Copy link
Member

flaix commented Nov 1, 2022

This can happen when the key cannot be parsed. Feedback in that case has been added to the web page now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐱 Defect Status-Done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spirritus @flaix @madukan