-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PluginManager setting #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Not sure if we can restart processes gracefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I went through the use cases and I think this PR is not yet working as it should.
Use case 1: Set Automatically close Git Extensions when installing plugins
= FALSE and try to uninstall a plugin which is used by a second GE instance.
What happens:
- The PM does not show any dialog
- All GE instances remain open
- Plugin not removed (plus, I get a popup from Windows User Account Control)
What should happen:
- The PM shows the dialog
- According to the selection all GE instances are either closed or remain open
- Plugin removed (if select to close GE)
Use case 2: Set Automatically close Git Extensions when installing plugins
= TRUE and try to uninstall a plugin which is used by a second GE instance.
What happens:
- The PM does show the dialog
- According to the selection all GE instances are either closed or remain open
- Plugin removed (if select to close GE)
What should happen:
- No dialog is shown
- All Git Extensions instances are closed
- Plugin removed
Yes, only works for installations. |
I think we discussed this some time ago (don't remember where and when). Restarting gracefully would at least include to reopen the repos I had opened (might be more than just 1 instance of GE), potentially also restore the window positions and other stuff. |
This requires a full session save function, if there is none. |
GitExtensions.exe --restore-last-session |
In context of several instances what does this mean?
…On Thu, 5 Nov. 2020, 10:36 am Ivan Grek, ***@***.***> wrote:
GitExtensions.exe --restore-last-session
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBTEXUPABDH3KYZDCNZW3DSOHQOVANCNFSM4S5IYU7A>
.
|
By process number in the order of the launches. |
LIFO Open 1, 2, 3; Like a stack. Looks like this. |
I'm not sure I understood you correctly. Is your doubt about when the close dialog should be shown and when not? When When
Maybe we should not focus primarily on the install part. IMHO, uninstall is more critical, since it can easily fail. |
I was confused by "Confirmation". |
Only confused by the behavior after canceling the confirmation. |
All GE instances remain open, plugin is not installed/updated/removed. |
fixes #35