Carefully handcrafted JavaScript classified as "generated"

[abrudz]

Some people use a terse coding style for popular languages like C and JavaScript, popularised by Arthur Whitney. An example of this is this PR which was wrongly classified as generated, when it is in fact carefully handcrafted. I don't know how Linguist detects generated code, but it should surely err on the side of considering code non-generated.

[lildude]

Linguist is detecting these files are likely to be minified and thus generated here:

linguist/lib/linguist/generated.rb

Lines 162 to 176 in c959cb5

	# Internal: Is the blob a minified file?
	#
	# Consider a file minified if the average line length is
	# greater then 110c.
	#
	# Currently, only JS and CSS files are detected by this method.
	#
	# Returns true or false.
	def minified_files?
	if maybe_minified? and lines.any?
	(lines.inject(0) { |n, l| n += l.length } / lines.length) > 110
	else
	false
	end
	end

but it should surely err on the side of considering code non-generated.

No. It is a lot more likely for such files to be legitimately minified than handcrafted. You can use an override for those rare cases where the files are handcrafted but fall into this calculation.