From 079c4ab5ee685da0dd87c7ecd79d5b1d5be65bad Mon Sep 17 00:00:00 2001
From: pedrocaseiro <pcaseiro96@gmail.com>
Date: Mon, 30 Oct 2017 21:26:31 +0000
Subject: [PATCH 1/3] Fieldset without a legend

---
 example.html |  5 +++++
 index.js     | 15 +++++++++++++++
 test/test.js | 16 ++++++++++++++++
 3 files changed, 36 insertions(+)

diff --git a/example.html b/example.html
index baef074..86b929f 100644
--- a/example.html
+++ b/example.html
@@ -42,6 +42,11 @@
       <a>Link</a>
       <p>Image without alt</p>
       <img src="https://github.com/octocat.png" width="50" height="50">
+
+      <p>Fieldset without legend</p>
+      <fieldset>
+        <p></p>
+      </fieldset>
     </div>
 
     <script type="text/javascript">
diff --git a/index.js b/index.js
index 32121f5..5ae61c8 100644
--- a/index.js
+++ b/index.js
@@ -38,6 +38,13 @@ export function scanForProblems(context, logError, options) {
       logError(new InputMissingLabelError(input))
     }
   }
+
+  for (const fieldset of context.querySelectorAll('fieldset')) {
+    if(!fieldset.firstChild || fieldset.firstChild.nodeName !== 'LEGEND'){
+      logError(new FieldsetMissingLegend(fieldset))
+    }
+  }
+
   if (options && options['ariaPairs']) {
     for (const selector in options['ariaPairs']) {
       const ARIAAttrsRequired =  options['ariaPairs'][selector]
@@ -117,6 +124,14 @@ function ARIAAttributeMissingError(element, attr) {
 }
 errorSubclass(ARIAAttributeMissingError)
 
+function FieldsetMissingLegend(element) {
+  this.name = 'FieldsetMissingLegend'
+  this.stack = new Error().stack
+  this.element = element
+  this.message = `Fieldset missing legend on ${inspect(element)}`
+}
+errorSubclass(FieldsetMissingLegend)
+
 function elementIsHidden(element) {
   return element.closest('[aria-hidden="true"], [hidden], [style*="display: none"]') != null
 }
diff --git a/test/test.js b/test/test.js
index 45fe096..23bbfa3 100644
--- a/test/test.js
+++ b/test/test.js
@@ -41,6 +41,14 @@ describe('scanForProblems should catch', () => {
 
     assert.equal(button.getAttribute('data-error'), 'ARIAAttributeMissingError')
   })
+
+  it('fieldset without legend', () => {
+    const fieldset = makeElement('fieldset', {"id": "fieldsetid"})
+    document.body.appendChild(fieldset)
+    const button = makeElement('button')
+    document.getElementById('fieldsetid').appendChild(button)
+    assert.equal(fieldset.getAttribute('data-error'), 'FieldsetMissingLegend')
+  })
 })
 
 describe('scanForProblems should not catch', () => {
@@ -83,6 +91,14 @@ describe('scanForProblems should not catch', () => {
     assert.notOk(label.getAttribute('data-error'))
     assert.notOk(input.getAttribute('data-error'))
   })
+
+  it('fieldset with legend', () => {
+    const fieldset = makeElement('fieldset', {"id": "fieldsetid"})
+    document.body.appendChild(fieldset)
+    const legend = makeElement('legend')
+    document.getElementById('fieldsetid').appendChild(legend)
+    assert.equal(fieldset.getAttribute('data-error'), 'FieldsetMissingLegend')
+  })
 })
 
 function makeElement(tag, attributes, content) {

From bdf6b4ff52fdfab1e0613f098fb4919ae04fd909 Mon Sep 17 00:00:00 2001
From: pedrocaseiro <pcaseiro96@gmail.com>
Date: Mon, 30 Oct 2017 21:28:41 +0000
Subject: [PATCH 2/3] Update readme with the error

---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 6fe8f05..52bbe63 100644
--- a/README.md
+++ b/README.md
@@ -34,6 +34,7 @@ List of errors:
 - `InputMissingLabelError`
 - `ButtonWithoutLabelError`
 - `ARIAAttributeMissingError`
+- `FieldsetMissingLegend`
 
 ## Scenario
 

From 5f52c61cbbc4b865c32c6ba78d5adf48e7de7f5a Mon Sep 17 00:00:00 2001
From: pedrocaseiro <pcaseiro96@gmail.com>
Date: Wed, 15 Nov 2017 17:57:22 +0000
Subject: [PATCH 3/3] Add white space that was making the build fail

---
 index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.js b/index.js
index 47c1d3f..a440cd8 100644
--- a/index.js
+++ b/index.js
@@ -55,7 +55,7 @@ export function scanForProblems(context, errorCallback, options) {
   }
 
   for (const fieldset of context.querySelectorAll('fieldset')) {
-    if(!fieldset.firstChild || fieldset.firstChild.nodeName !== 'LEGEND'){
+    if (!fieldset.firstChild || fieldset.firstChild.nodeName !== 'LEGEND') {
       logError(new FieldsetMissingLegend(fieldset))
     }
   }