From 96632630a93f02a6531cafd3eb53cebd8e235094 Mon Sep 17 00:00:00 2001 From: Paolo Tranquilli Date: Thu, 20 Feb 2025 11:59:26 +0100 Subject: [PATCH] Do some just+pre-commit tweaking * pre-commit: move the linting check ahead of the compiling one, as a typescript lint can change the compilaed javascript, so you can end up in a situation where the pre-commit check fails twice in a row * just: add linting and make the default to run all --- .pre-commit-config.yaml | 10 +++++----- justfile | 7 +++++++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e468c47091..e1ae3d243a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,17 +1,17 @@ repos: - repo: local hooks: + - id: lint-ts + name: Lint typescript code + files: \.ts$ + language: system + entry: npm run lint -- --fix - id: compile-ts name: Compile typescript files: \.[tj]s$ language: system entry: npm run build pass_filenames: false - - id: lint-ts - name: Lint typescript code - files: \.ts$ - language: system - entry: npm run lint -- --fix - id: pr-checks-sync name: Synchronize PR check workflows files: ^.github/workflows/__.*\.yml$|^pr-checks diff --git a/justfile b/justfile index 9bc9831373..5c0edef4df 100644 --- a/justfile +++ b/justfile @@ -1,3 +1,10 @@ +# Perform all working copy cleanup operations +all: lint sync + +# Lint source typescript +lint: + npm run lint -- --fix + # Sync generated files (javascript and PR checks) sync: build update-pr-checks