Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::set-output does not document that value cannot contain newlines #6693

Closed
jsoref opened this issue May 23, 2021 · 6 comments
Closed

::set-output does not document that value cannot contain newlines #6693

jsoref opened this issue May 23, 2021 · 6 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue pumpkin-spice Specifically tracked Hacktoberfest issue - internal purposes

Comments

@jsoref
Copy link
Contributor

jsoref commented May 23, 2021

What article on docs.github.com is affected?

https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-output-parameter

What part(s) of the article would you like to see updated?

It should indicate that value cannot contain newlines.

Additional information

https://github.community/t/use-ssh-key-from-secret-in-output-set-output/141071/2
https://github.community/t/set-output-truncates-multiline-strings/16852/3

Content design plan

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label May 23, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 23, 2021
@github github deleted a comment May 25, 2021
@janiceilene
Copy link
Contributor

Thanks for opening an issue @jsoref! I'll triage this for the team to take a look 👀

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels May 25, 2021
@lecoursen lecoursen self-assigned this May 27, 2021
@lecoursen
Copy link
Member

Thanks @jsoref! The solution in https://github.community/t/set-output-truncates-multiline-strings/16852/3 would be good to document. You or anyone else is welcome to do so!

@lecoursen lecoursen added the help wanted Anyone is welcome to open a pull request to fix this issue label May 27, 2021
@jsoref
Copy link
Contributor Author

jsoref commented May 27, 2021

@lecoursen: I found the solution so icky that I didn't want to be blamed for documenting it (c.f. https://github.community/t/set-output-truncates-multiline-strings/16852/5), hence just filing a bug asking that it be documented as opposed to writing the documentation.

That said, once it is officially documented, I'll be quite happy to point to it / rely on it to work 😄 .

@janiceilene janiceilene added the needs content strategy Wait to open a PR until there's an approved content strategy in the issue label Jun 18, 2021
@myarb myarb removed the needs content strategy Wait to open a PR until there's an approved content strategy in the issue label Jun 23, 2021
@github-actions github-actions bot added stale There is no recent activity on this issue or pull request and removed stale There is no recent activity on this issue or pull request labels Nov 29, 2021
@aisgbnok aisgbnok moved this to Watching in Community Contributions Mar 30, 2022
@cmwilson21 cmwilson21 added the pumpkin-spice Specifically tracked Hacktoberfest issue - internal purposes label Sep 30, 2022
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Aug 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@github-project-automation github-project-automation bot moved this from Watching to Done in Community Contributions Aug 21, 2023
@jsoref
Copy link
Contributor Author

jsoref commented Aug 22, 2023

Sigh

@cmwilson21 cmwilson21 reopened this Aug 22, 2023
@github-project-automation github-project-automation bot moved this from Done to Requires Changes in Community Contributions Aug 22, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 22, 2023
@cmwilson21 cmwilson21 removed stale There is no recent activity on this issue or pull request triage Do not begin working on this issue until triaged by the team labels Aug 22, 2023
@Muhammad-Saleem1Ch

This comment was marked as off-topic.

@mark-mxwl
Copy link
Contributor

mark-mxwl commented Dec 14, 2023

Hi @jsoref and @lecoursen!

It seems that in the time since this issue was posted, it has been solved with the introduction of GITHUB env files. Substituting set-output with $GITHUB_OUTPUT, in conjunction with a delimiter, allows for multiline output. These options are already documented in the two sections immediately preceding the one linked to this issue.

Ref closed issue #21529 with regard to using a delimiter for multiline output.

As there is a planned deprecation for the set-output command, I would recommend that this issue be marked as closed.

@jsoref jsoref closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@github-project-automation github-project-automation bot moved this from Requires Changes to Done in Community Contributions Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue pumpkin-spice Specifically tracked Hacktoberfest issue - internal purposes
Projects
None yet
Development

No branches or pull requests

11 participants
@jsoref @janiceilene @myarb @lecoursen @cmwilson21 @mark-mxwl @Muhammad-Saleem1Ch and others