peerDependencies incompatible with dependency @eslint/compat

[silverwind]

This package depends on "@eslint/compat": "^1.2.3" which specifies:

  "peerDependencies": {
    "eslint": "^9.10.0"
  },

which is incompatible with the module's peer dependencies:

eslint-plugin-github/package.json

Line 60 in abcfc3b

"eslint": "^8 || ^9"

This results in a npm warning upon installation when eslint@8 is present:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn   dev eslint@"8.57.0" from the root project
npm warn   41 more (@babel/eslint-parser, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional eslint@"^9.10.0" from @eslint/[email protected]
npm warn node_modules/eslint-plugin-github/node_modules/@eslint/compat
npm warn   @eslint/compat@"^1.2.3" from [email protected]
npm warn   node_modules/eslint-plugin-github

The peer dependency was added in eslint/rewrite#106.

[akielbas]

Any suggestions for a fix?

[silverwind]

The only fix I see is to to downgrade @eslint/compat to v1.1.1, the last version which did not have this peer dependency.

The problem only affects package managers that handle peer dependencies strictly like npm does without legacy-peer-deps. It's not an issue with pnpm for example.

Oh and there's one more option of course: drop eslint 8 support.