[Bug]: ASCII art for empty contribution shows grid filled with all high-level blocks

[siddharthkoli]

GitHub CLI Version

2.63.2

gh-skyline Version

0.0.4

What Operating System are you seeing the problem on?

Linux

What happened?

Running the extension for an empty contribution graph gives a grid filled with all high-level blocks.
I ran it with -u chrisreddington and -y 2013.

Running with -f however outputs blank blocks.

Is that the expected behaviour or a bug?

PS: I ran it on Codespaces

[chrisreddington]

An interesting bug, thanks @siddharthkoli 🙏. I think the code normalises based on all contributions that have come back, so if you pick an empty year, then 'everything' would appear the same.

Replicated on my side, so I'll remove the triage label. Could be a good issue if anyone is up for taking a look at this one!

I assume the expected behaviour would be to see a grid of gaps, rather than a grid of blocks? So I think an approach to a fix could be checking whether there were any contributions throughout that period.

[siddharthkoli]

Can I work on this please? I was looking for good first issues for contributing. 🙂

[siddharthkoli]

I assume the expected behaviour would be to see a grid of gaps, rather than a grid of blocks? So I think an approach to a fix could be checking whether there were any contributions throughout that period.

The same as -f flag in the screenshot? A grid of gaps is essentially empty right?

[chrisreddington]

Can I work on this please? I was looking for good first issues for contributing. 🙂

That would be great, thank you 🎉 🙏

I assume the expected behaviour would be to see a grid of gaps, rather than a grid of blocks? So I think an approach to a fix could be checking whether there were any contributions throughout that period.

The same as -f flag in the screenshot? A grid of gaps is essentially empty right?

Yep, exactly that 😄 I think the difference with -f or --full is that it pulls in data from other years, which means a 'zero' contribution is an empty contribution. Whereas if you happen to pick a year that has no contributions, then they all get normalised to being a contribution.

[siddharthkoli]

@chrisreddington

is this fine or would it be better if I collapsed the blank space completely like with the -f option I posted in the initial comment?