Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net::LDAP.new deprecation warning #100

Open
tkanov opened this issue Apr 6, 2017 · 2 comments
Open

Net::LDAP.new deprecation warning #100

tkanov opened this issue Apr 6, 2017 · 2 comments

Comments

@tkanov
Copy link

tkanov commented Apr 6, 2017

When encryption parameter is passed as String to Net::LDAP.new

ldap_options = {
  ...
  encryption: 'ssl',
}
ldap = GitHub::Ldap.new ldap_options

it produces the following deprecation warning
Deprecation warning: please give :encryption option as a Hash to Net::LDAP.new

At present, the encryption value must be a Hash with parameters, which consists of two keys:
method: - :simple_tls or :start_tls
tls_options: - Hash of options for that method

@tkanov
Copy link
Author

tkanov commented Apr 6, 2017

A PR to fix #99

@tkanov
Copy link
Author

tkanov commented May 2, 2017

up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@tkanov and others