-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: add missing Continue support to release workflow and agent scripts #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitsoni007
wants to merge
7
commits into
github:main
Choose a base branch
from
rohitsoni007:add-continue-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
β6
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8cc6a9b
feat: add Continue support to Spec Kit
rohitsoni007 1aadf66
update continue uses promptsfoldeer
rohitsoni007 ce4f166
update releases
rohitsoni007 cea96d0
update for auto adding /command in continue
rohitsoni007 5139e98
Merge branch 'main' into add-continue-support
rohitsoni007 52bbf82
Refactor YAML frontmatter insertion into generic function for continuβ¦
rohitsoni007 67888c8
conflict resolve
rohitsoni007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this function needs to be more generic, that is - have a separate function for insertion of custom YAML frontmatter into prompt files, and then invoke it with the argument of
invokableand a value oftrue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored the code to extract the YAML frontmatter insertion logic into a separate, more generic function called
insert_yaml_frontmatter. This function can now be reused for other field insertions in the future.The new function takes four parameters:
body: The content to processname: The name to use for thespeckit.{name}entryfield_name: The field name to insert (e.g., "invokable")field_value: The value for that field (e.g., "true")This approach makes the code more maintainable and follows the DRY principle. When the agent is "continue" and a description is present, it still inserts the
name: speckit.{name}andinvokable: truefields into the YAML frontmatter of the prompt files, but now does so by calling the generic function with the appropriate parameters.This also makes it easier to add other custom fields in the future without duplicating the AWK logic.