Skip to content

Commit d9d1bff

Browse files
committed
Increase timeout for skeleton wizard tests
We've now added more tests and pushed the total duration over 5 seconds for all the tests in this file. In general it seems like for components that are heavily tested, we're increasing the default timeout. At the moment this makes it seem like you're doing something wrong if a file with tests takes more than 5 seconds, when in actual fact the limit seems arbitrary. I wonder if we could reverse this and set timeouts of 5 seconds only where they're needed.
1 parent 1fa3bda commit d9d1bff

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

extensions/ql-vscode/test/vscode-tests/cli-integration/skeleton-query-wizard.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ import { testCredentialsWithStub } from "../../factories/authentication";
1313
import { DatabaseItem, DatabaseManager } from "../../../src/local-databases";
1414
import * as databaseFetcher from "../../../src/databaseFetcher";
1515

16+
// The tests in this file take longer than the default 5 seconds to run,
17+
// so we're increasing the timeout.
18+
jest.setTimeout(20_000);
19+
1620
describe("SkeletonQueryWizard", () => {
1721
let wizard: SkeletonQueryWizard;
1822
let dir: tmp.DirResult;

0 commit comments

Comments
 (0)