Skip to content

Improvements to skeleton query flow #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2023
Merged

Improvements to skeleton query flow #2256

merged 6 commits into from
Apr 12, 2023

Conversation

@elenatanasoiu
Copy link
Contributor

@elenatanasoiu elenatanasoiu commented Mar 31, 2023

Please review this PR commit-by-commit.

Follow up to #2250 where we added a wizard which will guide you through generating an example query based on the language of your choice.

The wizard would then create a skeleton QL pack and download an appropriate database for you, so that you could focus on just writing your query.

We've received some feedback on improvements for this flow:

  1. If a database using the same language is already downloaded, re-use that database instead of downloading a new one.
  2. Show the user a selection box before downloading our suggested database. The selection box will have our suggested database pre-filled but will require the user to press "Ok" to download it. The user can choose to type in a different database instead.
Screen.Recording.2023-03-31.at.18.34.55.mov

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from 89b148b to 70523b2 Compare April 3, 2023 11:11
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 67d384b to 3b736aa Compare April 3, 2023 11:14
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch 3 times, most recently from c00240a to 0253b5d Compare April 3, 2023 13:39
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 3b736aa to 4f294a4 Compare April 3, 2023 13:43
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from 0253b5d to 7d28e61 Compare April 3, 2023 13:52
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 4f294a4 to be267b1 Compare April 3, 2023 13:54
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from 7d28e61 to 2f70963 Compare April 3, 2023 14:00
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from be267b1 to 15600cb Compare April 3, 2023 14:02
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch 11 times, most recently from 0545eb5 to 699c362 Compare April 3, 2023 16:54
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch 4 times, most recently from eefe804 to a07b11c Compare April 3, 2023 17:44
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from 699c362 to f61440d Compare April 3, 2023 17:46
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from a07b11c to 91b591c Compare April 3, 2023 17:47
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from f61440d to 7691955 Compare April 3, 2023 17:57
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 91b591c to 1fa3bda Compare April 3, 2023 17:57
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from fd25ba4 to d9d1bff Compare April 3, 2023 18:16
@elenatanasoiu elenatanasoiu marked this pull request as ready for review April 4, 2023 08:28
@elenatanasoiu elenatanasoiu requested a review from a team as a code owner April 4, 2023 08:28
@elenatanasoiu elenatanasoiu requested a review from a team April 4, 2023 08:28
koesie10
koesie10 reviewed Apr 4, 2023
View reviewed changes
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-wizard-query branch from e198a79 to 460da1e Compare April 11, 2023 15:00
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from d9d1bff to c577bee Compare April 11, 2023 16:06
@elenatanasoiu elenatanasoiu mentioned this pull request Apr 11, 2023
Merged
@elenatanasoiu
Re-use existing database if one for the same language is already down…
3e3eb0d 
…loaded

We'd like to select an existing database for our query, if on is
already downloaded and matches the query language.

Previously we were re-using the database if the language and name
matched (e.g. the name would be `github/codeql`).
@elenatanasoiu
Show the user a selection box before downloading database
919219c 
At the moment, we're always deciding which database to download for the
user for an example query.

We'd like to give them a chance to change the database, so here we're
adding a step where we're showing the user a selection box with the
suggested database pre-filled.

They can choose to type in a different database before continuing the
skeleton generation process.
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from c577bee to 919219c Compare April 11, 2023 16:54
@elenatanasoiu
Copy link
Contributor Author

elenatanasoiu commented Apr 12, 2023 •
edited
Loading

Ok! I think this is also ready for a re-review.

I've also tested manually that things still work as expected.

@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 92d8d83 to 6f6d0e2 Compare April 12, 2023 09:13
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 6f6d0e2 to de4afae Compare April 12, 2023 09:17
koesie10
koesie10 approved these changes Apr 12, 2023
View reviewed changes
Base automatically changed from elena/yer-a-wizard-query to main April 12, 2023 16:07
@elenatanasoiu @koesie10
Shorten check for progress
6fc6f39 
Co-authored-by: Koen Vlaswinkel <[email protected]>
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 7414004 to 6fc6f39 Compare April 12, 2023 16:11
@elenatanasoiu elenatanasoiu merged commit a48b1f8 into main Apr 12, 2023
@elenatanasoiu elenatanasoiu deleted the elena/yer-a-lizard-query branch April 12, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elenatanasoiu @koesie10