Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ambiguity from 'View logs' messages #3181

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Remove ambiguity from 'View logs' messages #3181

merged 2 commits into from
Jan 3, 2024

Conversation

norascheuch
Copy link
Contributor

This PR removes ambiguity of our 'View logs' messages.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch requested review from a team as code owners January 2, 2024 13:25
@norascheuch norascheuch force-pushed the nora/adjust-log-messages branch from 07ef5ac to cfbc443 Compare January 2, 2024 13:52
koesie10
koesie10 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should actions be capitalized as Actions since it's the name of a product?

@norascheuch
Copy link
Contributor Author

@koesie10 That's a good point 🤔 I went with what @jf205 suggested in the issue, so I would leave it as is for now.

@norascheuch norascheuch merged commit 8daf337 into main Jan 3, 2024
14 checks passed
@norascheuch norascheuch deleted the nora/adjust-log-messages branch January 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norascheuch @koesie10