Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package-lock.json to have acorn as a direct dependency #3930

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

koesie10
Copy link
Member

This fixes npm run storybook by ensuring that node_modules/acorn is installed on the same level as node_modules/acorn-jsx. I'm not sure why we have this discrepancy.

Screenshot 2025-02-19 at 09 55 07

@koesie10 koesie10 marked this pull request as ready for review February 19, 2025 09:19
@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 09:19
@koesie10 koesie10 requested a review from a team as a code owner February 19, 2025 09:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@robertbrignull
Copy link
Contributor

What commands did you run to make these package-lock.json changes?

@koesie10
Copy link
Member Author

What commands did you run to make these package-lock.json changes?

I manually removed the nested node_modules/acorn items (for example this item and this item) and then ran npm install. That moved the node_modules/acorn line to be at the top level.

Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was mostly worried that future changes might accidentally undo this, perhaps if one of these other packages that depends on acorn gets updated. Hopefully that's unlikely unless the package-lock.json file gets completely discarded and recreated. 🤞🏼

@koesie10 koesie10 merged commit 7a37825 into main Feb 19, 2025
28 checks passed
@koesie10 koesie10 deleted the koesie10/fix-acorn branch February 19, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants