Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Use the query parameter to filter an env in UI #499

Open
noahingh opened this issue Nov 8, 2022 · 1 comment · May be fixed by #502
Open

Use the query parameter to filter an env in UI #499

noahingh opened this issue Nov 8, 2022 · 1 comment · May be fixed by #502
Labels
component: ui This issue or pull request is related to the feature of the UI-side
Milestone
v0.8.0

Comments

@noahingh
Copy link
Member

noahingh commented Nov 8, 2022

It would be better to use query parameters when searching the deployment list of the environment. Because users expect the deployment list stays when users return from another page. Also, page could be a query parameter.
@noahingh noahingh added the component: ui This issue or pull request is related to the feature of the UI-side label Nov 8, 2022
@noahingh
Copy link
Member Author

noahingh commented Nov 13, 2022 •
edited
Loading

FYI, The next version of react-router-dom, v6, supports the method to get search parameters. So we need to upgrade the package version in this issue, too. Here is the document on how to upgrade react-router-dom from v5 to v6.

@noahingh noahingh linked a pull request Nov 13, 2022 that will close this issue
Open
@noahingh noahingh added this to the v0.8.0 milestone Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ui This issue or pull request is related to the feature of the UI-side
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Use the query parameter to search deployment gitploy-io/gitploy
1 participant
@noahingh