Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to reach the current comment in issue #776

Open
ShalokShalom opened this issue Apr 17, 2018 · 4 comments
Open

Impossible to reach the current comment in issue #776

ShalokShalom opened this issue Apr 17, 2018 · 4 comments
Assignees

Comments

@ShalokShalom
Copy link

Question Response
Version? current testing
Devices tested? BlackBerry Passport

What Currently Happens?

Infinite scrolling in that issue:
golang/go#21161

What Do You Expect To Happen?

To reach the bottom. So, the most fresh post.

My Reproduction Steps

Went into that issue, try to scale down.

@machour
Copy link
Member

machour commented Apr 18, 2018

Hi @ShalokShalom !

Your issue description is a bit cryptic.. is the issue that you can only see the first comments? (last visible one being from opennota 9 months ago)

If that's it, then this will be fixed soon as we're currently in the process of migrating to GraphQL, where will be able to show all the comments & events on the issue, even when there are tons of them.

I'm not really found of infinite scrolling for issues, as sometimes you just want to see how the discussions ended, without having to scroll pages of pages of comments.

I find the way github web deals with this really neat: https://github.com/npm/registry/issues/255

They show a few comments from the beggining, a few from the end, and the User needs to click to load more comments:

capture

What would you think if we mimicked this UX?

@ShalokShalom
Copy link
Author

To be honest, I think this approach from Github can get easily skipped.

If you do that, then much more visible.

And yes, you guessed my issue correct:
9 months back is all what I can see.

@machour machour reopened this Apr 18, 2018
@machour
Copy link
Member

machour commented Apr 18, 2018

I totally see what you mean, as I didn't see it twice while looking for it to take the screenshot 😆
We'll make sure it's way more visible.

Keeping this issue opened as the problem isn't solved yet.

@ShalokShalom
Copy link
Author

Ah, I thought this is tracked anywhere else

@machour machour self-assigned this Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants