Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GizaModel #38

Open
Gonmeso opened this issue Apr 17, 2024 · 4 comments
Open

Refactor GizaModel #38

Gonmeso opened this issue Apr 17, 2024 · 4 comments
Labels
enhancement New feature or request ODHack

Comments

@Gonmeso
Copy link
Contributor

Gonmeso commented Apr 17, 2024

When creating the tests for the GizaModel there were a lot of patching involved, multiple client calls, and thus in makes it harder also to test GizaAgent as it is an extension of the model.

When encountering such needs for patching in the test, that also indicates that we might have over complicated the design of GizaModel, specially the __init__.

We should aim to improve the design of this entity to:

  • Provide a better public API
  • Ease testing
  • Add corner cases handling
  • Create specific exceptions regarding model usage

This changes should not affect the current usage if the predict method, as it is basically the entrypoint used by the users, but the underlying logic can be greatly improved.

@Gonmeso Gonmeso added the enhancement New feature or request label Apr 17, 2024
@LuisDi98
Copy link

LuisDi98 commented Apr 22, 2024

I would like to take this issue. Solid designs principles may improve this init()
Do we have any group in case of deeper questions about the project?

@Gonmeso
Copy link
Contributor Author

Gonmeso commented Apr 22, 2024

Hi @LuisDi98 I've assigned it to you, have in mind that designing will need also input fro our side.

@LuisDi98
Copy link

LuisDi98 commented Jul 8, 2024

Sorry... I've been having troubles with personal stuff... And I consider is better to unassign it... The ODHack6.0 is coming soon the July 25th. I'm really sorry for not completing the issue, thanks a lot for the chance @Gonmeso
I hope the new dev can fix it 🔥

@LuisDi98 LuisDi98 removed their assignment Jul 8, 2024
@EmmanuelAR
Copy link
Contributor

Hello @Gonmeso can I take this ? I already worked on this repo in the past, let me know 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ODHack
Projects
None yet
Development

No branches or pull requests

4 participants