-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GizaModel #38
Comments
I would like to take this issue. Solid designs principles may improve this init() |
Hi @LuisDi98 I've assigned it to you, have in mind that designing will need also input fro our side. |
Sorry... I've been having troubles with personal stuff... And I consider is better to unassign it... The ODHack6.0 is coming soon the July 25th. I'm really sorry for not completing the issue, thanks a lot for the chance @Gonmeso |
Hello @Gonmeso can I take this ? I already worked on this repo in the past, let me know 🤗 |
When creating the tests for the
GizaModel
there were a lot of patching involved, multiple client calls, and thus in makes it harder also to testGizaAgent
as it is an extension of the model.When encountering such needs for patching in the test, that also indicates that we might have over complicated the design of
GizaModel
, specially the__init__
.We should aim to improve the design of this entity to:
This changes should not affect the current usage if the
predict
method, as it is basically the entrypoint used by the users, but the underlying logic can be greatly improved.The text was updated successfully, but these errors were encountered: