Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Escape expression inputs for the case of PHP-proxies (foreign or domestic) using the extract variable #3

Open
chl0e3e opened this issue Aug 29, 2022 · 4 comments

Comments

@chl0e3e
Copy link

chl0e3e commented Aug 29, 2022

Code

All inputs to CLI systems should be escaped for security reasons. Also recommended to add blacklists for CLI functions and/or remove them.

@gizmore
Copy link
Owner

gizmore commented Sep 1, 2022

GDOv7 is not really planned as a multi-user system, but it should and (?:could)* be? +asap

Thanks for this!

@gizmore
Copy link
Owner

gizmore commented Sep 1, 2022

A milestone here is to have two linux user accounts to share the same gdo installation (this is actually a speedup as the pathes are in opcache)

Thx for your input!

  • giz

@gizmore
Copy link
Owner

gizmore commented Sep 1, 2022

One could write a phpgdo-multiuser module that switches configs based on usernames? O.o (brrr)

@gizmore
Copy link
Owner

gizmore commented Sep 1, 2022

Escaping should only be done to untrusted user input. For example you can mark GDTs Traiting WithTitle as being ->escaped().

@todo: Automaticall mark GDO having GDT_Title as being escaped. (I bet there are XSS lurking atm)

As a user you might want to add plain html.

Actually GDOv7 GDT_Message - (user content OUCH!) - is based on a simple <textarea> that allows plain html to style your posts.

It uses htmlpurifier to sanitize the user input.

There are gdo modules available to change the GDT_Message editor to a wysiwyg editor (currently only some Module_Markdown (without file support atm).

  • giz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants