Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of Grid images on the bottom row of a grid #188

Open
KenFarr opened this issue Aug 16, 2023 · 6 comments
Open

Alignment of Grid images on the bottom row of a grid #188

KenFarr opened this issue Aug 16, 2023 · 6 comments

Comments

@KenFarr
Copy link

KenFarr commented Aug 16, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Versions you are currently using (please complete the following information):

  • Moodle: [e.g. 4.1]
  • Format: [e.g. 401.1.0]
  • Browser and version [e.g. Chrome Version 108.0.5359.125 (Official Build) (64-bit) on Windows 10]

** Funding **
All new features / improvements need to be financially funded. There might be a few exceptions where I decide that I'll learn something new or want to add the functionality, but this will be on a case by case basis.

Hi Gareth
As per email, I would like to request a feature that allows the user in each Moodle course using grid format to decide how grid format behaves if the bottom row is not not full. This has become more important as we use the Section breaks system so have the same issue after each section break. picture attached to show what I mean. On row three and row five of this grid I would like the option of images floating left.

thanks
Ken

grid

@gjb2048
Copy link
Collaborator

gjb2048 commented Aug 16, 2023

Dear @KenFarr,

I'm currently using 'space-between', please see https://css-tricks.com/snippets/css/a-guide-to-flexbox/#aa-justify-content - so technically there is only one row for a group of grid boxes, either with no or one or more section breaks. This is to allow the wrapping to work. Clearly if I use 'flex-start' or 'flex-end' then this will lead to space either to the right or the left, or at least an imbalance on one side. Would 'center' or 'space-around' in theory look better for you?

Kind regards,

Gareth

@gjb2048
Copy link
Collaborator

gjb2048 commented Aug 16, 2023

E.g:

Screenshot 2023-08-16 132723
Screenshot 2023-08-16 133047
Screenshot 2023-08-16 133019
Screenshot 2023-08-16 132843

@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 21, 2023

Dear @KenFarr,

Related to: #191

Kind regards,

Gareth

@gjb2048
Copy link
Collaborator

gjb2048 commented Sep 26, 2023

@KenFarr Please note a change in the URL -> #188

@gjb2048 gjb2048 removed Pending investigation Triaged Issue read and is on backlog labels Oct 4, 2023
@gjb2048
Copy link
Collaborator

gjb2048 commented Oct 4, 2023

@KenFarr This has now been implemented in #191 for M4.1+ versions. Do you require backporting to M4.0?

@gjb2048
Copy link
Collaborator

gjb2048 commented Jun 19, 2024

@KenFarr Are you happy that this is complete please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants