Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display human readable peer name for smartphone connections. #100

Closed
gkoh opened this issue Jun 25, 2024 · 2 comments · Fixed by #127
Closed

Display human readable peer name for smartphone connections. #100

gkoh opened this issue Jun 25, 2024 · 2 comments · Fixed by #127
Assignees
Labels
enhancement New feature or request mobile device Related to mobile devices
Milestone

Comments

@gkoh
Copy link
Owner

gkoh commented Jun 25, 2024

The current BLE library does not provide an easy way to get the smartphone name during connection, we use the bluetooth MAC address at the moment.
However, there are changes coming that will make this possible.
Thus, rather than being asked to connect to unreadable "AA:BB:CC:....", we should be able to ask to connect to "My smartphone".

@gkoh gkoh added enhancement New feature or request mobile device Related to mobile devices labels Jun 25, 2024
@gkoh gkoh added this to the v2.1.0 milestone Jun 25, 2024
@gkoh gkoh self-assigned this Jul 6, 2024
@gkoh gkoh modified the milestones: v2.1.0, v3.0.0 Jul 7, 2024
@gkoh
Copy link
Owner Author

gkoh commented Aug 15, 2024

This requires changes that are only available in an unstable release of NimBLE-Arduino. As of writing, the latest release is 1.4.2.

@gkoh
Copy link
Owner Author

gkoh commented Aug 16, 2024

This is the commit that serves our needs:
h2zero/NimBLE-Arduino@44a69ed

gkoh added a commit that referenced this issue Sep 16, 2024
Fix #100 by updating to a development cut of NimBLE-Arduino.
Whilst here improve device bond handling, this makes subsequent
pair/forget sequences a little less iffy.
@gkoh gkoh linked a pull request Sep 16, 2024 that will close this issue
@gkoh gkoh modified the milestones: v3.0.0, v2.2.0 Sep 16, 2024
@gkoh gkoh closed this as completed in #127 Sep 18, 2024
gkoh added a commit that referenced this issue Sep 18, 2024
* Add per-camera task and queue.

Lay the foundation for supporting simultaneous, parallel camera
connections.

The UI now sends commands to the control task, which relays them to
per-camera tasks.
This allows the UI and each connected camera to operate asynchronously.

Increase limit maximum clients from 3 to 8.

* Display human readable mobile device names.

Fix #100 by updating to a development cut of NimBLE-Arduino.
Whilst here improve device bond handling, this makes subsequent
pair/forget sequences a little less iffy.

* Implement multi-connect.

M5ez:
Add context to menu item advanced function.

Furble:
Tweak NimBLE settings.
Remove scan duration, now scan forever as we can stop on demand.
Drop global interval_t, load as needed to reduce variable scope.

Add setting to toggle multi-connect.
Modify connection menu to support tagging cameras.
Add ability to connect to all tagged cameras.

Cannot get directed advertising to mobile devices so still disabled.

Multi-connect to mobile devices is super iffy, not recommended for
production use.

* Tweak the code style a little.

Fix minor error in shutter lock formatting, introduced when migrating
from String to std::string.

Also removed unused macros.

* Update clang-format action version.

* Fix m5stack-core build.

* Minor style updates.

Move some more code into std::string native and const a few more
parameters.

* Further C++ refactoring.

Refactor the Camera type into the base Camera class.
Refactor fillSaveName into CameraList class, it is only used there.
Style adjustments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mobile device Related to mobile devices
Projects
None yet
1 participant