Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Widget Title #279

Open
DallasHoff opened this issue Dec 15, 2024 · 4 comments
Open

Extension Widget Title #279

DallasHoff opened this issue Dec 15, 2024 · 4 comments
Labels
work completed Work for this has been completed but it may not yet be merged / released
Milestone

Comments

@DallasHoff
Copy link

DallasHoff commented Dec 15, 2024

I've set up an extension widget, and I noticed that setting a title in the widget config has no effect if the extension sends a title in the Widget-Title header.

- type: extension
  title: Foo
  url: http://example.com

In this case, I would expect the config to take precedence and make the widget's title render as "Foo" but the header takes precedence instead. Is this intended?

@svilenmarkov
Copy link
Member

Hey, thanks for bringing this up. I think you have a good point and it is something I overlooked, I'll get it sorted out with the next release so that the title defined in the config takes priority.

@svilenmarkov svilenmarkov added this to the v0.7.0 milestone Dec 15, 2024
@svilenmarkov svilenmarkov added the work completed Work for this has been completed but it may not yet be merged / released label Dec 15, 2024
@Anachron
Copy link

Hey, this also related to other widgets: Repository for example always displays Repository no matter which one I display.

When displayed in tabs, this will show Repository several times. Should I open a new issue for this, @svilenmarkov?

@svilenmarkov
Copy link
Member

Hey @Anachron, I purposefully didn't want to automatically change the repository widget title to the repository name because I wanted to avoid the repetition of:

image

Like with all widgets, you can still manually change the title to whatever you like and that title will also be used for groups:

- type: group
  widgets:
    - type: repository
      title: Glance Repository
      repository: glanceapp/glance
    - type: repository
      title: Immich Repository
      repository: immich-app/immich

image

I don't consider this to be a bug, though feel free to open a new issue if you think the behavior could be improved.

@Anachron
Copy link

Ugh, sorry I am new to glance, I totally did overlook that https://github.com/glanceapp/glance/blob/main/docs/configuration.md#widgets part. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work completed Work for this has been completed but it may not yet be merged / released
Projects
None yet
Development

No branches or pull requests

3 participants