Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha wrapper appears to be broken #5

Open
StoneCypher opened this issue Jun 20, 2016 · 0 comments
Open

Mocha wrapper appears to be broken #5

StoneCypher opened this issue Jun 20, 2016 · 0 comments

Comments

@StoneCypher
Copy link
Contributor

Crap

It looks like the Mocha wrapper is broken.

Justification:

  1. Take your example code
  2. Change the property to assert that 3 > 5, meaning it should break every time
  3. Watch it report pass

Observation:

It smelled funky to me that there was an it/2 in the example code, and also an it/2 inside the wrapper. I've used Mocha for almost three hours now, and my understanding is that its do not nest.

Therefore, I removed the interior it/2 from the wrapper. Suddenly things started working.

I also returned the value of the forAll, pretty much just because.

Suggested remediation:

  1. Observe that my garbage fixes it
  2. Figure out why
  3. Throw my gargbage out, because the author (me) didn't put in any effort
  4. Fix it correctly instead
  5. Accept that nobody ever does this, ever
  6. Merge the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant