Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code in glidein_startup #298

Open
mmascher opened this issue May 26, 2023 · 1 comment
Open

Remove obsolete code in glidein_startup #298

mmascher opened this issue May 26, 2023 · 1 comment

Comments

@mmascher
Copy link
Contributor

There have been a couple of issues related to environment setup:

https://ggus.eu/index.php?mode=ticket_info&ticket_id=161645#update#5
https://ggus.eu/index.php?mode=ticket_info&ticket_id=161024

I believe this code (which si 15 years old) is not needed anymore in the container world we live in:

########################################
# Setup OSG and/or Globus
if [ -r "${OSG_GRID}/setup.sh" ]; then
. "${OSG_GRID}/setup.sh"
else
if [ -r "${GLITE_LOCAL_CUSTOMIZATION_DIR}/cp_1.sh" ]; then
. "${GLITE_LOCAL_CUSTOMIZATION_DIR}/cp_1.sh"
fi
fi
if [ -z "${GLOBUS_PATH}" ]; then
if [ -z "${GLOBUS_LOCATION}" ]; then
# if GLOBUS_LOCATION not defined, try to guess it
if [ -r "/opt/globus/etc/globus-user-env.sh" ]; then
GLOBUS_LOCATION=/opt/globus
elif [ -r "/osgroot/osgcore/globus/etc/globus-user-env.sh" ]; then
GLOBUS_LOCATION=/osgroot/osgcore/globus
else
warn "GLOBUS_LOCATION not defined and could not guess it."
warn "Looked in:"
warn ' /opt/globus/etc/globus-user-env.sh'
warn ' /osgroot/osgcore/globus/etc/globus-user-env.sh'
warn 'Continuing like nothing happened'
fi
fi
if [ -r "${GLOBUS_LOCATION}/etc/globus-user-env.sh" ]; then
. "${GLOBUS_LOCATION}/etc/globus-user-env.sh"
else
warn "GLOBUS_PATH not defined and ${GLOBUS_LOCATION}/etc/globus-user-env.sh does not exist."
warn 'Continuing like nothing happened'
fi
fi
set_proxy_fullpath() {
# Set the X509_USER_PROXY path to full path to the file
if fullpath="$(readlink -f "${X509_USER_PROXY}")"; then
echo "Setting X509_USER_PROXY ${X509_USER_PROXY} to canonical path ${fullpath}" 1>&2
export X509_USER_PROXY="${fullpath}"
else
echo "Unable to get canonical path for X509_USER_PROXY, using ${X509_USER_PROXY}" 1>&2
fi
}
[ -n "${X509_USER_PROXY}" ] && set_proxy_fullpath

Should we remove it? Is there anything that is set up there that the pilot needs? The user job should find everything they need in the container.

@mmascher
Copy link
Contributor Author

Here is another issue caused by this code: https://ggus.eu/?mode=ticket_info&ticket_id=164040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant