Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure GLIDEIN_MaxMemMBs and GLIDEIN_CPUS are treated as float #375

Open
mambelli opened this issue Dec 6, 2023 · 0 comments
Open

Make sure GLIDEIN_MaxMemMBs and GLIDEIN_CPUS are treated as float #375

mambelli opened this issue Dec 6, 2023 · 0 comments
Assignees
Labels
cms CMS stakeholder documentation for affected component factoryops Factory Operations stakeholder FEATURE For FEATURES glidein for affected component High High priority

Comments

@mambelli
Copy link
Contributor

mambelli commented Dec 6, 2023

Is your feature request related to a problem? Please describe.
In PR #374 GLIDEIN_MaxMemMBs and GLIDEIN_CPUS become float after the overload adjustment
All variables in shell are strings so copying them around is not a problem
But there is some math involving these 2 that may still use let or (( )), both working only with integer values.
This should be checked and corrected to use bc or something else working also w/ floats.

NOTE that GLIDEIN_MaxMemMBs, GLIDEIN_CPUS_EXPECTED, and GLIDEIN_CPUS should remain integer values in the configuration so as not to complicate Glidein provisioning in the Frontend and monitoring

Describe the solution you'd like
To treat correctly GLIDEIN_MaxMemMBs and GLIDEIN_CPUS as float, using bc or something else working also w/ floats.

Describe alternatives you've considered
NA

Info (please complete the following information):

  • Priority: high
  • Stakeholders: CMS, FactoryOps
  • Components: glidein, documentation

Additional context
NA

@github-actions github-actions bot added cms CMS stakeholder documentation for affected component factoryops Factory Operations stakeholder FEATURE For FEATURES glidein for affected component High High priority labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cms CMS stakeholder documentation for affected component factoryops Factory Operations stakeholder FEATURE For FEATURES glidein for affected component High High priority
Projects
None yet
Development

No branches or pull requests

2 participants