Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review inital feedbacks #2

Open
pankaj-ag opened this issue Aug 1, 2022 · 0 comments
Open

Code Review inital feedbacks #2

pankaj-ag opened this issue Aug 1, 2022 · 0 comments

Comments

@pankaj-ag
Copy link
Contributor

pankaj-ag commented Aug 1, 2022

  1. Get javascript content from another file. If we can load it from a js then it will be great.
  2. Remove all unwanted packages, it will decrease the load time.
  3. We need to move the fetch data logic to a different file.
  4. Add a licence file
  5. Variable naming is not consistent, please use a more meaningful full name.
  6. Filters should be an assosiative array instead of index based (if possible)
@pankaj-ag pankaj-ag changed the title Code Review feedbacks Code Review inital feedbacks Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant