Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaks in Base64 strings #3

Open
gllmflndn opened this issue Aug 30, 2019 · 0 comments
Open

Line breaks in Base64 strings #3

gllmflndn opened this issue Aug 30, 2019 · 0 comments

Comments

@gllmflndn
Copy link
Owner

Sometimes Base64 strings contain line breaks (typically) every 76 characters: they should be ignored as well as any other character that is not in the Base64 character list. This is implemented in base64decode.m:
https://github.com/gllmflndn/gifti/blob/master/%40gifti/private/base64decode.m#L36-L39
but not in base64.c. Fixing this will probably result in cancelling the speed advantage of the current C implementation with respect to other ones.
Base64 encoding should not be modified to include line breaks.

See e.g.:

<Data>AhkAAANGAAACZAAABTcAAAJkAAADRgAAAmQAAAU3AACDEQAAA0YAAEIGAAAFNwAAgxEAAANkAAAC
ZAAABGQAAAJkAAADZAAAAmQAAARkAAACGQAAA2QAAMUNAAAEZAAAYwQAAAJGAACILwAABGQAAIgv
AAACRgAA
</Data>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant