Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arches] Fix Azure Storage preventing concept from being deleted #163

Open
veuncent opened this issue Jan 7, 2019 · 0 comments
Open

[Arches] Fix Azure Storage preventing concept from being deleted #163

veuncent opened this issue Jan 7, 2019 · 0 comments
Assignees

Comments

@veuncent
Copy link

veuncent commented Jan 7, 2019

archesproject/arches#4168

https://github.com/archesproject/arches/blob/master/arches/app/models/models.py#L709

Adam's comment:
you can see that we have some error handling set up to handle s3, but I think you'll probably be able to improve this (an explicit Exception catch would be good). Just looking at this comment https://stackoverflow.com/questions/5372934/how-do-i-get-django-admin-to-delete-files-when-i-remove-an-object-from-the-datab#comment39798273_16443037 I think you'll be able to solve it. It would also be good to update the comment in that code, as the order of the answers on the SE question has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant