Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL.language always set to en #4308

Open
aetdr opened this issue Nov 12, 2024 · 5 comments
Open

GL.language always set to en #4308

aetdr opened this issue Nov 12, 2024 · 5 comments
Assignees

Comments

@aetdr
Copy link

aetdr commented Nov 12, 2024

What version of GlobaLeaks are you using?

5.0.22

What browser(s) are you seeing the problem on?

All

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

Hi @evilaliv3

The javascript property GL.language is always set to EN (english) in version 5.0.22
Usually the value represents the selected/active language code.

Proposed solution

No response

@evilaliv3
Copy link
Member

Thank you for reporting this @aetdr

Is this still the case in release 5.0.26? would you please check?

@evilaliv3
Copy link
Member

\cc @msmannan00

@msmannan00
Copy link
Member

Noted will check it

@msmannan00
Copy link
Member

msmannan00 commented Nov 14, 2024

the issues lies in function determineLanguage() {
GL.language = state.language = bestLanguage(facts);
if (state.language !== "*") {
updateTranslationServices(state.language);
$window.document.getElementsByTagName("html")[0].setAttribute("lang", state.language);
}
}
which has not been migrated to angular2 during client update that is why it is pulling default en value from the mock. the scope however are actually working, will create the patch and make pull request shortly

@aetdr
Copy link
Author

aetdr commented Nov 14, 2024

Thank you @msmannan00

evilaliv3 pushed a commit that referenced this issue Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants