Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of a functionality to enable forwarding of reports from the root tenant to secondary tenants #4330

Open
evilaliv3 opened this issue Nov 21, 2024 · 2 comments

Comments

@evilaliv3
Copy link
Member

evilaliv3 commented Nov 21, 2024

Proposal

This ticket is related to the work of analysis and integration of a feature currently proposed in #4314 to enable recipients of the root tenant to forward reports to primary to users of the secondary sites.

@evilaliv3
Copy link
Member Author

evilaliv3 commented Nov 21, 2024

Status of the current implementation:

  • Through observed demos the functionality seems very complete
  • The implementation miss a feature enabler
  • The implementation involve an encryption implementation and significant database change to be verified

Actions necessary to possibly integrate same functionality:

  • Implement an web admin interface with an enabler of the functionality at platform level to be set as disabled so that existing users are not impacted
  • Implement client or at least backend tests to validate the functionality of the client intervention and the security of the backend API

@evilaliv3 evilaliv3 changed the title Integration of a functionality to enable to share reports from the root tenant to secondary tenants Integration of a functionality to enable forwarding of reports from the root tenant to secondary tenants Nov 21, 2024
evilaliv3 added a commit that referenced this issue Nov 23, 2024
Changes:
- Add 'forwarding' enabler variable to enable/disable forwarding module at site level (default false)
- Renamed 'eo_internaltip_id' to 'forwarding_internaltip_id' considering future possible exention
  of the the functionality to enable to forward reports both to other sites regardless they are
  external or affiliated
@evilaliv3
Copy link
Member Author

I've proceeded with the full revision of the proposed changes to database included in this implementation.

The revisions consider to be just addition of variables necessary to enable/disable the new feature in the UI and changes in naming necessary for globaleaks for international naming conventions and code consistency that are:

  • Add 'forwarding' enabler variable to enable/disable forwarding module at site level (default false)
  • Renamed 'eo_internaltip_id' to 'forwarding_internaltip_id' considering future possible exention
    of the the functionality to enable to forward reports both to other sites regardless they are
    external or affiliated

We have avoided other structural changes understanding this could have major requirements in the refactoring of the code proposing the minimum changes necessary and proposing only the changes already previously indicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant