Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On release 5 injection of images via Markdown seem not working #4341

Closed
elbill opened this issue Dec 1, 2024 · 9 comments
Closed

On release 5 injection of images via Markdown seem not working #4341

elbill opened this issue Dec 1, 2024 · 9 comments

Comments

@elbill
Copy link

elbill commented Dec 1, 2024

What version of GlobaLeaks are you using?

5.0.32

What browser(s) are you seeing the problem on?

Chrome

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

In version 4 markdown was enabled in question descriptions. This is no longer the case and only links show active as pached following issue #4340. I had some markdown implementations in description showing odd now.

Proposed solution

I would suggest bringing back markdown in question descriptions as well as enabling it in other elements such as information showing after selecting specific question and blocked question.

@evilaliv3
Copy link
Member

@elbill : actually markdown is enabled on question description.

would you please provide an example of the syntax that you are using and the output that you are getting?

@elbill
Copy link
Author

elbill commented Dec 1, 2024

It used to render the images as links to an external platform. now the markdown code shows as in the example

Doping Cipher

image

image

@elbill
Copy link
Author

elbill commented Dec 1, 2024

So i was using thumdnails as links to external elearning content. The thumbnail images dont show any more.

@evilaliv3
Copy link
Member

Are you using markdown or html?

Maybe you were using some html tags and the old component was accepting it?

@elbill
Copy link
Author

elbill commented Dec 1, 2024

What is the following. This what I was using
image
it showed the thumbnails perfectly

@evilaliv3
Copy link
Member

Thank you @elbill.

I just retried with this code and it works like a charm [![Doping center](/s/image.png)](https://www.google.it)

Please check your browser console to understand the problem on your browser.
Maybe the issue is caused by the revision of you content-security-policy that may have introduced some errors?

P.S. if possible when provided code like the above please do a simple code paste of the code as it make it more fast to test the code without having to manually read and type all the provided code. thank you!!

@evilaliv3 evilaliv3 changed the title Markdown not enabled in question descriptions. On release 5 injection of images via Markdown seem not working [unconfirmed] Dec 2, 2024
@elbill
Copy link
Author

elbill commented Dec 2, 2024

havent made any modification in CSP.
please check:
https://fraudline.try.globaleaks.org/#/
landing page and questionaire
I'm providing password in slack

@evilaliv3 evilaliv3 changed the title On release 5 injection of images via Markdown seem not working [unconfirmed] On release 5 injection of images via Markdown seem not working Dec 2, 2024
@evilaliv3
Copy link
Member

Thank you.

The bug comes from the combination of images and links and seems to be related to this commit: a6bd235

evilaliv3 added a commit that referenced this issue Dec 2, 2024
@evilaliv3
Copy link
Member

Corrected and the fix will be included in 5.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants