Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Definitions #1134

Open
jmccrae opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1165
Open

Duplicate Definitions #1134

jmccrae opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1165
Labels
definition A definition needs to be updated synset duplicate A synset has been claimed as a duplicate validation check A method should be implemented to verify the validity of the resource
Milestone
2025 Release

Comments

@jmccrae
Copy link
Member

jmccrae commented Nov 6, 2024

Some synsets in OEWN have duplicate definitions. See this file for details:

dupes.txt

These should all be fixed by either merging duplicates or changing definitions to be non-unique.

Further, once this is done, we should add a validation check that ensures that no definition can be duplicate in the resource
@jmccrae jmccrae added synset duplicate A synset has been claimed as a duplicate definition A definition needs to be updated validation check A method should be implemented to verify the validity of the resource labels Nov 6, 2024
@jmccrae jmccrae added this to the 2025 Release milestone Nov 29, 2024
@goodmami goodmami mentioned this issue Dec 4, 2024
Closed
@jmccrae jmccrae linked a pull request Jan 17, 2025 that will close this issue
Remove duplicates #1165
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
definition A definition needs to be updated synset duplicate A synset has been claimed as a duplicate validation check A method should be implemented to verify the validity of the resource
Projects
None yet
Milestone
2025 Release
Development

Successfully merging a pull request may close this issue.

Remove duplicates globalwordnet/english-wordnet
1 participant
@jmccrae