Link short examples #61
Conversation
|
G'day, Almost all done! Two of the links appear to be illformed (for attribute and other). Similar has a '*'! Please check carefully before you submit the PR. I made some hand changes to hypernym/hyponym, could you please merge them carefully? |
|
shoat is a fairly obscure word (at least I had never heard of it). It shows that my labeling algorithm is imperfect (or at least does not have enough frequency data). Can you change the lemma to piglet instead? |
|
I will check and make the above corrections |
There was a problem hiding this comment.
When changing something like "X (relation) Y" to "X has (relation) Y" or "X is a (relation) of Y", be careful you're not reversing the direction. Also, I noticed several words with the wrong sense linked. I did not check all of them, so there are probably more.
gwadoc/doc_en.py
Outdated
| * *dictionary* ``hyponym`` *wordbook* | ||
| * `beef <ILIURL/48244>`_ has hyponym `meat <ILIURL/77100>`_ | ||
| * `pear <ILIURL/77892>`_ has hyponym `edible fruit <ILIURL/77500>`_ | ||
| * `dictionary <ILIURL/70226>`_ has hyponym `wordbook <ILIURL/70225>`_ |
There was a problem hiding this comment.
While the bottom three examples needed to be changed, they (and first example) have changed their meaning. They all should be "X is a hyponym of Y" and not "X has hyponym Y".
gwadoc/doc_en.py
Outdated
| @@ -2173,7 +2173,7 @@ | |||
|
|
|||
| An opposite and inherently incompatible word. | |||
| """ | |||
| relations.antonym.ex.en = "Smart has antonym Stupid" | |||
| relations.antonym.ex.en = "`smart <ILIURL/2474>`_ has antonym `stupid <ILIURL/2478>`_" | |||
| relations.antonym.exe.en = """ | |||
| * `man <ILIURL/48657>`_ has antonym `woman <ILIURL/94168>`_ | |||
There was a problem hiding this comment.
This is the wrong sense of 'man'. It should be <ILIURL/91182>.
There was a problem hiding this comment.
Also "sell" below should be <ILIURL/32953>.
gwadoc/doc_en.py
Outdated
| @@ -1326,13 +1326,13 @@ | |||
| A relation between two concepts where concept A makes up a part of | |||
| concept B. | |||
| """ | |||
| relations.meronym.ex.en = "hand has part-meronym finger" | |||
| relations.meronym.ex.en = "`hand <ILIURL/48471>`_ has part-meronym `finger <ILIURL/53712>`_" | |||
There was a problem hiding this comment.
Wrong sense of "finger". Try <ILIURL/66162>
gwadoc/doc_en.py
Outdated
| @@ -1363,7 +1363,7 @@ | |||
| A relation between two concepts where concept A makes up a | |||
| part of concept B. | |||
| """ | |||
| relations.holonym.ex.en = "finger has part-holonym hand" | |||
| relations.holonym.ex.en = "`finger <ILIURL/53712>`_ has part-holonym `hand <ILIURL/48471>`_" | |||
To be clear, I would appreciate it if you went through all the linked concepts and verified that they are the correct sense. I found this easier looking at the built site because i could just click on the words to see what they linked to. For instance, the "hand has part-meronym finger" example links to a sense of the finger of a glove, not the finger of a hand. In some cases, like "brother is an antonym of sister", both are (probably) the wrong sense, because they are currently the male/female members of an organization senses instead of male/female siblings ones. |
|
I think this is the most urgent of your remaining tasks.
…On Fri, Nov 27, 2020 at 7:53 PM Michael Wayne Goodman < ***@***.***> wrote:
I did not check all of them, so there are probably more.
To be clear, I would appreciate it if you went through all the linked
concepts and verified that they are the correct sense.
I found this easier looking at the built site because i could just click
on the words to see what they linked to. For instance, the "hand has
part-meronym finger" example links to a sense of the finger of a glove, not
the finger of a hand. In some cases, like "brother is an antonym of
sister", both are (probably) the wrong sense, because they are currently
the *male/female members of an organization* senses instead of *male/female
siblings* ones.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIPZRSDYC7J6MWBHXTUTV3SR6HMNANCNFSM4TLX7E4Q>
.
--
Francis Bond <http://www3.ntu.edu.sg/home/fcbond/>
Division of Linguistics and Multilingual Studies
Nanyang Technological University
|
What this PR does