Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website redesign #66

Open
wants to merge 15 commits into
base: gsod
Choose a base branch
from
Open

Conversation

gconnect
Copy link
Contributor

@gconnect gconnect commented Nov 20, 2020

What this PR does

New Design
image

@fcbond
Copy link
Member

fcbond commented Nov 21, 2020

The color is nice, but when I click on a link, it is not aligned properly: instead the first part is hidden. Here is what happens when I click on participle.

Screenshot from 2020-11-21 23-47-02

@fcbond
Copy link
Member

fcbond commented Nov 21, 2020

you were asked in the meeting to make the text a little more compact, by e.g. reducing spacing between the formal properties or in the lists of examples. Can you please look into that.

@gconnect
Copy link
Contributor Author

I will make the above corrections. Thanks for your reviews.

@fcbond
Copy link
Member

fcbond commented Nov 22, 2020

I thought about this more overnight (it is easier to think with the mock-up, thank you).

  • I think the header should be shorter to save screen space
    • can we have "Global wordnet association * Open WordNet Documentation * search" all on the same line
  • the colours you have selected are from Princeton's site, and are Princeton Universities colors. I think that might be misleading.
  • Let's try and go with blue and grey, like Rohitesh is doing for the OMW
  • https://github.com/orgs/globalwordnet/teams/documentation/discussions/11

@fcbond
Copy link
Member

fcbond commented Nov 22, 2020

For the compression, we could also do it by shifting things around. For example we could go
name 'symbol' (id) ⮀ reverse
short def: short example

e.g.:
Hyponym '⊂' (hyponymhypernym)
"a word that is more specific than a given word" --- dog is a hyponym of animal
applicability synset–synset

Domain Topic (domain_topic has_domain_topic)
"A concept which is the scientific category pointer of a given concept." --- computer science is a domain topic of CPU
applicability synset–synset; sense–synset; sense–sense

If you can do something clever so that if the screen is too narrow the example starts on a new line, that would be even nicer:

Domain Topic (domain_topic has_domain_topic)
"A concept which is the scientific category pointer of a given concept."
--- computer science is a domain topic of CPU
applicability synset–synset; sense–synset; sense–sense

@gconnect
Copy link
Contributor Author

I think it will be better I go with the color combination from my second mockup. I am not too cool with the color combination from Robitech. Please take a look at the second mockup color again. Mainwhile what is the main color for Global WordNet Association?

@fcbond
Copy link
Member

fcbond commented Nov 23, 2020 via email

@gconnect
Copy link
Contributor Author

image
Uploading image.png…

@gconnect
Copy link
Contributor Author

For the compression, we could also do it by shifting things around. For example we could go
name 'symbol' (id) ⮀ reverse
short def: short example

e.g.:
Hyponym '⊂' (hyponymhypernym)
"a word that is more specific than a given word" --- dog is a hyponym of animal
applicability synset–synset

Domain Topic (domain_topic has_domain_topic)
"A concept which is the scientific category pointer of a given concept." --- computer science is a domain topic of CPU
applicability synset–synset; sense–synset; sense–sense

If you can do something clever so that if the screen is too narrow the example starts on a new line, that would be even nicer:

Domain Topic (domain_topic has_domain_topic)
"A concept which is the scientific category pointer of a given concept."
--- computer science is a domain topic of CPU
applicability synset–synset; sense–synset; sense–sense

I have made the changes. Using this format.

@fcbond
Copy link
Member

fcbond commented Dec 1, 2020

Hi,

this is an improvement, but it would be better if:

  • the title page stayed at the top
  • there was a separator between relations in the main page
  • the navbar is much tighter -- maybe lose the lines?
    • on a small screen you can't see the end
  • you were going to hide the toc by default (and have it toggleable)

@gconnect
Copy link
Contributor Author

Hi,

this is an improvement, but it would be better if:

  • the title page stayed at the top

  • there was a separator between relations in the main page

  • the navbar is much tighter -- maybe lose the lines?

    • on a small screen you can't see the end
  • you were going to hide the toc by default (and have it toggleable)

I am not quite sure what you meant by the title page staying at the top and adding lose lines to the navbar

@gconnect
Copy link
Contributor Author

gconnect commented Dec 28, 2020

image
image
image
Uploading image.png…

@gconnect
Copy link
Contributor Author

Hi,

this is an improvement, but it would be better if:

  • the title page stayed at the top

  • there was a separator between relations in the main page

  • the navbar is much tighter -- maybe lose the lines?

    • on a small screen you can't see the end
  • you were going to hide the toc by default (and have it toggleable)

I have made the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants