Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom asset definitions add noticeable request performance hit #18304

Closed
cconard96 opened this issue Nov 13, 2024 · 2 comments · Fixed by #18454
Closed

Custom asset definitions add noticeable request performance hit #18304

cconard96 opened this issue Nov 13, 2024 · 2 comments · Fixed by #18454
Assignees
@cconard96
Labels
beta performance

Comments

@cconard96
Copy link
Contributor

cconard96 commented Nov 13, 2024 •
edited
Loading

I've noticed that as I add more custom asset definitions for testing (or from running E2E tests locally), almost every request to a PHP script has gotten nearly 10x slower than what it is in 10.0/bugfixes. Currently, I have 70 asset definitions with a few custom fields in each. It isn't clear yet if the issue is the number of definitions, number of custom fields, specific capacities, or a combination of everything.
@cconard96 cconard96 changed the title Request performance slower than 10.0 Custom asset definitions add noticeable request performance hit Nov 13, 2024
@cconard96
Copy link
Contributor Author

Identified the IsInventoriableCapacity as the source of the performance hit. I only had a single asset definition with it enabled and it alone was adding 550ms to the response times.

@cconard96 cconard96 mentioned this issue Nov 14, 2024
Closed
4 tasks
@AdrienClairembault
Copy link
Contributor

I confirm on my side too.

Without IsInventoriableCapacity:
Image

With one IsInventoriableCapacity:
Image

@cconard96 cconard96 self-assigned this Nov 21, 2024
cedric-anne added a commit to cedric-anne/glpi that referenced this issue Dec 3, 2024
@cedric-anne
Add the ability to implement a specific logic when a capacity is enabled
cda2d12 
fixes glpi-project#18304
@cedric-anne cedric-anne mentioned this issue Dec 3, 2024
Merged
3 tasks
cedric-anne added a commit to cedric-anne/glpi that referenced this issue Dec 3, 2024
@cedric-anne
Add the ability to implement a specific logic when a capacity is enabled
779dafe 
fixes glpi-project#18304
trasher pushed a commit that referenced this issue Dec 4, 2024
@cedric-anne @trasher
Add the ability to implement a specific logic when a capacity is enabled
d8a9111 
fixes #18304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cconard96 cconard96

Labels
beta performance
Projects
None yet
Milestone
No milestone
2 participants
@cconard96 @AdrienClairembault