Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quintic functions are misnamed #6

Open
aferriss opened this issue May 23, 2020 · 3 comments
Open

Quintic functions are misnamed #6

aferriss opened this issue May 23, 2020 · 3 comments

Comments

@aferriss
Copy link

Hi there, thanks for providing these functions, such a great resource!

All the quintic functions are misspelled as qintic without the u. The filenames are correct however, it's just the functions names that are defined with the typo.

@bmschmidt
Copy link

This is fixed in #8.

For glslify, Is it possible/desirable to export the same function under two different names for case current code is using the 'qintic' spelling?
Are there non-glslify cases where the mis-spelling should need to be maintained?

@rreusser
Copy link
Member

@bmschmidt Yeah, I think that's best. Maybe just move the implementation to the properly named one and then just re-export it in the incorrectly named file? (so that the implementations don't accidentally diverge in case someone maintains it and misses the bugfix)

@rreusser
Copy link
Member

Also, thanks for working on this!! 👏 🙏 I hang around and try to facilitate maintenance from time to time… I think I have permission to actually deploy these fixes and/or add you as someone who can. Don't hesitate to @-ping me if something needs to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants