Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with 1.81 #968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build with 1.81 #968

wants to merge 1 commit into from

Conversation

iriri
Copy link

@iriri iriri commented Dec 3, 2024 •
edited
Loading

As of 1.81, stringify appears to always insert spaces between tokens, resulting in type names like std :: io :: File. Switching to concat avoids this issue.

Due to the use of local_inner_macros, we fully qualify concat and stringify in the definition of field_decl_inner.

Fixes #966.
Fixes #967.

@iriri
Fix build with 1.81
41b9278 
As of 1.81, `stringify` appears to always insert spaces between tokens,
resulting in type names like `std :: io :: File`. Switching to `concat`
avoids this issue.

Due to the use of `local_inner_macros`, we fully qualify `concat` and
`stringify` in the definition of `field_decl_inner`.
Marwes
Marwes requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Marwes Marwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI is failing due to the lockfile being old, causing some nightly issues in dependencies, a cargo update should take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marwes Marwes Marwes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with Rust 1.81.0+ results in broken repl binary gluon-repl fails to import stdlib
2 participants
@iriri @Marwes