feat: suppport equals sign in can-i-deploy pacticipant selector param…

…eters Fixes: pact-foundation#55
gmolki · Jan 21, 2020 · 90f6457 · 90f6457
1 parent 3690944
commit 90f6457
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/pact_broker/client/cli/version_selector_options_parser.rb b/lib/pact_broker/client/cli/version_selector_options_parser.rb
@@ -1,11 +1,14 @@
+# frozen_string_literal: true
+
 module PactBroker
   module Client
     module CLI
       class VersionSelectorOptionsParser
+
         def self.call words
           selectors = []
           previous_option = nil
-          words.each do | word |
+          split_equals(words).each do | word |
             case word
             when "--pacticipant", "-a"
               selectors << {}
@@ -33,6 +36,16 @@ def self.call words
           end
           selectors
         end
+
+        def self.split_equals(words)
+          words.flat_map do |word|
+            if word.start_with?("-") && word.include?("=")
+              word.split('=', 2)
+            else
+              word
+            end
+          end
+        end
       end
     end
   end

diff --git a/spec/lib/pact_broker/client/cli/version_selector_options_parser_spec.rb b/spec/lib/pact_broker/client/cli/version_selector_options_parser_spec.rb
@@ -39,6 +39,15 @@ module CLI
           ],[
             ["--pacticipant", "Foo", "--all", "prod", "--pacticipant", "Bar"],
             [{ pacticipant: "Foo", tag: "prod"}, { pacticipant: "Bar" } ]
+          ],[
+            ["--pacticipant=Foo", "--version=1.2.3"],
+            [{ pacticipant: "Foo", version: "1.2.3" } ]
+          ],[
+            ["--pacticipant=Foo=Bar", "--version", "1.2.3"],
+            [{ pacticipant: "Foo=Bar", version: "1.2.3" } ]
+          ],[
+            ["--pacticipant", "Foo=Bar", "--version", "1.2.3"],
+            [{ pacticipant: "Foo=Bar", version: "1.2.3" } ]
           ]
         ]