fix: Aushm use ruby 2.2 syntax (pact-foundation#110)

* fix: use ruby < 2.3 syntax. v1.6.1 added code that uses ruby's safe navigation operator which was only available for ruby versions >= 2.3. Since this gem has ruby requirement of >= 2.0, this will create issues for users using ruby < 2.3, such as users using version 1.88.84 of pact-foundation/pact-ruby-standalone which ships with travelling ruby version 2.2. * ci (fix maybe): try 0.0.18 approval Co-authored-by: Aushadhee Mahakumarage <[email protected]>
gmolki · May 9, 2022 · b006ad7 · b006ad7
1 parent 55668a9
commit b006ad7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/pact_broker/client/cli/version_commands.rb b/lib/pact_broker/client/cli/version_commands.rb
@@ -48,8 +48,8 @@ def create_or_update_version(*required_but_ignored)
               params = {
                 pacticipant_name: options.pacticipant.strip,
                 version_number: options.version.strip,
-                branch_name: options.branch&.strip,
-                tags: options.tag&.collect(&:strip)
+                branch_name: options.branch && options.branch.strip,
+                tags: options.tag && options.tag.collect(&:strip)
               }
 
               execute_version_command(params, "Create")

diff --git a/pact-broker-client.gemspec b/pact-broker-client.gemspec
@@ -33,6 +33,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'conventional-changelog', '~>1.3'
   gem.add_development_dependency 'pact', '~> 1.16'
   gem.add_development_dependency 'pact-support', '~> 1.16'
-  gem.add_development_dependency 'approvals', '0.0.24'
+  gem.add_development_dependency 'approvals', '0.0.18' 
   gem.add_development_dependency 'rspec-its', '~> 1.3'
 end