Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars duplicated for Netlify Github Action #55

Open
sw360cab opened this issue Sep 12, 2024 · 0 comments
Open

Env vars duplicated for Netlify Github Action #55

sw360cab opened this issue Sep 12, 2024 · 0 comments

Comments

@sw360cab
Copy link
Contributor

When running Netlify Github Action, the following env vars:

  • MEILISEARCH_URL
  • MEILISEARCH_INDEX_UID
  • MEILISEARCH_API_KEY

are reported twice:

  • in netlify.toml, which is the reference file for Netlify deploys, in the [context.production.environment] section
  • in .github/workflows/netlify.yml, which performs the build (pure build in yarn) using the env vars and then deploys to Netlify (referring to netlify.toml)

The variables should be centralized in a single place, however is not clear:

  • why the build step in the Github Action is not performed using the steps described in the build section of netlify.toml
  • if [context.production.environment] section is the right place to define these env vars, or it is useless (IMHO) to have them here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant