Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gno lint actually executes code #3547

Closed
leohhhn opened this issue Jan 19, 2025 · 1 comment · Fixed by #3597
Closed

gno lint actually executes code #3547

leohhhn opened this issue Jan 19, 2025 · 1 comment · Fixed by #3597
Assignees

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jan 19, 2025

Description

Seems that when gno lint runs, it also has a specific context, and executes init functions; This context can contain OrigCaller & PrevRealm addresses that will fail for some ownable scenarios and lint errors in those cases.

With tests, we solve this with TestSetXYZ functions but this is obviously impossible with lint (and shouldn't be the case).

Check this code and this job.

h/t @ajnavarro

@thehowl
Copy link
Member

thehowl commented Jan 20, 2025

We can likely add a PreprocessMemPackage method, that runs similar to RunMemPackage, but without running the init functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

4 participants