Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages workflow should be tested #3572

Closed
thehowl opened this issue Jan 21, 2025 · 1 comment · Fixed by #3607
Closed

gh-pages workflow should be tested #3572

thehowl opened this issue Jan 21, 2025 · 1 comment · Fixed by #3607
Assignees
Labels
🐞 bug Something isn't working

Comments

@thehowl
Copy link
Member

thehowl commented Jan 21, 2025

@Villaquiranm see this workflow fail: https://github.com/gnolang/gno/actions/runs/12888293723/job/35932866096

I think we should do two things:

  1. Ensure we test the build workflow even in PRs, so if this workflow breaks we know ahead of time. (Possibly also for the other gh-pages workflow, maybe we can use the same workflow file but avoid publishing to the branch).
  2. We should not use GOROOT as the variable where to store the GOROOT variable, as it overrides the GOROOT determined by the go binary and can cause a mess; so I'd say we replace that with something like GOROOT_SAVE.

We should also specify in the README of stdlib_diff that the version being checked against is the toolchain version in the go.mod.

@Villaquiranm
Copy link
Contributor

Villaquiranm commented Jan 24, 2025

Sure @thehowl I've created a PR for it thanks 💯

#3607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants