[r/boards] [meta] tests

[salmad3]

Context:

This META issue tracks filetest coverage for all publicly callable methods in the boards realm.

Each checkbox corresponds to creating filetests (or updating existing ones) that thoroughly cover that function’s logic and edge cases.

render.gno:

• Render(path string) string
  • Boards Listing
    • Empty boards (0 boards) → shows “no items.”
    • Bulk boards (50+) → verify pagination with ?page=...; test out-of-bounds pages.
  • Board View
    • Check hidden threads do not appear or appear flagged.
    • Invalid board name or unknown board → error message.
  • Thread View
    • If thread is hidden, show “Thread has been flagged…”
    • Large threads (100+ posts) → pagination.
  • Reply View
    • Display hidden replies as flagged, but child replies still visible.
    • Non-existent reply → error message.

public.gno:

• GetBoardIDFromName(name string) (BoardID, bool) @jeronimoalbi

  • Checks name collisions vs. existing boards (Naming → duplicates).
  • If board does not exist, returns false.
  • Possibly ensure “board name = user name” scenario is handled (Naming → user realm conflict).

• CreateBoard(name string) BoardID @jeronimoalbi

  • Permissions: Must have board:create. Unauthorized → panic.
  • Naming: Duplicate names → “board already exists.” <6 chars → panic, address-like → panic, user realm conflict → panic.
  • Load: Creating 50+ boards to confirm listing/pagination.

• RenameBoard(name, newName string) @jeronimoalbi

  • Permissions: Must have rename permission (WithPermission).
  • Existing: If newName used, panic “board already exists.”
  • Address/Short: If <6 chars or address-like → panic.
  • Aliases: Confirm repeated renames (A→B, B→C).

• FlagThread(bid BoardID, postID PostID, reason string) @jeronimoalbi

  • Permissions: Must have thread:flag.
  • Single-Flag: If threshold=1, hides immediately; second flag → “already flagged.”
  • Multiple-Flags: If threshold>1, final flag hides.
  • Already Hidden: Additional flags may panic or do nothing.
  • Unauthorized: Must panic if lacking thread:flag.

• CreateThread(bid BoardID, title, body string) PostID @jeronimoalbi

  • Permissions: Must have thread:create.
  • Board Existence: If board missing, fail.
  • Private Board: Non-member fails if invite-only.
  • Body: Large/empty body check.
  • Load: Test 100+ threads, confirm render pagination.

• CreateReply(bid BoardID, threadID, replyID PostID, body string) PostID @jeronimoalbi

  • Permissions: Possibly thread:create or any member.
  • Hidden Thread: Must fail “thread was hidden.”
  • Nested: If replyID != threadID, replying to another reply.
  • Unauthorized: If private board, non-member fails.

• FlagReply(bid BoardID, threadID, replyID PostID, reason string) @jeronimoalbi

  • Permissions: Need reply:flag.
  • Threshold: Single/multi-flag hide.
  • Already Hidden: Additional flags → panic/do nothing.
  • Reply Existence: If missing, fail.

• CreateRepost(bid BoardID, threadID PostID, title, body string, dstBoardID BoardID) PostID @x1unix

  • Permissions: Need thread:repost.
  • Hidden Thread: If original hidden, fail “flagged.”
  • Private Board: Must be a member if private.
  • Cross-Board: Check repost counters, possible chain A→B→C.

• DeleteThread(bid BoardID, threadID PostID) @jeronimoalbi

  • Permissions: thread:delete.
  • Nonexistent: “thread does not exist.”
  • Hidden: If already hidden, do we allow a “hard delete”?
  • Replies: Removing all replies or blocked?

• DeleteReply(bid BoardID, threadID, replyID PostID) @jeronimoalbi

  • Permissions: reply:delete.
  • Nonexistent: “reply not found: X.”
  • Nested: If it has children, block or cascade?

• EditThread(bid BoardID, threadID PostID, title, body string) @jeronimoalbi

  • Permissions: thread:edit or thread owner.
  • Hidden: If hidden, do we allow editing?
  • Large/Empty: Confirm no meltdown.

• EditReply(bid BoardID, threadID, replyID PostID, title, body string) @jeronimoalbi

  • Creator vs. Admin: Only original author or an admin?
  • Hidden: If reply hidden, typically no edit.
  • Large/Empty: Similar checks.

• InviteMember(bid BoardID, user std.Address, role Role) @jeronimoalbi

  • Permissions: member:invite; unauthorized → panic.
  • Double Invite: “user already exists.”
  • Invite as Owner: Possibly restricted to owners only.

• RemoveMember(bid BoardID, user std.Address) @jeronimoalbi

  • Permissions: member:remove.
  • Remove Owner: If last owner, disallowed?
  • Nonexistent: “member not found.”

• HasMemberRole(bid BoardID, member std.Address, role Role) bool @jeronimoalbi

  • Basic checks: returns false if user missing.
  • Unknown role → false.
  • Possibly test multiple roles or superRole.

• ChangeMemberRole(bid BoardID, member std.Address, role Role) @jeronimoalbi

  • Permissions: role:change.
  • Admin → Owner or removing last owner, confirm rules.

Cross-Cutting Scenarios (Concurrency, Fuzzing, Load):

Some scenarios apply globally across multiple functions:

• Load & Stress
  • Bulk creation of boards/threads/replies.
  • High concurrency or rapid calls (e.g., multiple invites, multiple flags).
• Fuzz & Random
  • Provide random inputs for board names, addresses, roles. Catch partial states or unexpected panics.

We can incorporate these into existing filetests (for example, a filetest that tries to create 1,000 threads or random board names), or separate them out if that’s simpler.

Notes:

• Some testing already exists.
• We will keep this issue open until every function is fully tested. Please add any newly introduced public methods here as well, so we track them from the start.

[salmad3]

@jeronimoalbi @x1unix you can add your name beside the functions in issue description.

[x1unix]

@salmad3 please add this to CreateRepost: #3659