Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Save button behavior for Layouts #949

Open
manueljordan opened this issue Sep 13, 2024 · 1 comment
Open

Fix the Save button behavior for Layouts #949

manueljordan opened this issue Sep 13, 2024 · 1 comment

Comments

@manueljordan
Copy link

When a custom layout is created or even when an already custom layout is edited, when the Save button is pressed it resets by complete all about:

  • Profile
  • Custom Command
  • Working directory

Therefore all the settings are lost

So far the unique and correct approach to really save either the new or current layout is press the Close button

vssdeo added a commit to vssdeo/terminator that referenced this issue Dec 11, 2024
…ve button in layout overrides the profile, custom command, working dir. The same does not happen when close button is pressed or pref window is closed. In my observation,I have seem that the profile is overwritten, but custom command and wording dir are updated.

The updation of working dir and custom command when editing without save button seems a bit different but I haven't changed that part for now.

For sake of consistency I have ensured the updatation of profile (which anyways gets updated from drop down menu) but is over written by save button, happens when save button is pressed.
@vssdeo
Copy link
Contributor

vssdeo commented Dec 11, 2024

Its reported in the issue that the save button in layout overrides the profile, custom command, working dir. The same does not happen when close button is pressed or pref window is closed. In my observation,I have seen that the profile is overwritten, but custom command and wording dir are updated.

The updation of working dir and custom command when editing without save button seems a bit different but I haven't changed that part for now.

For sake of consistency I have ensured the updation of profile (which anyways gets updated from drop down menu) but is over written by save button, happens when save button is pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants