Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: seding chain id and remote #142

Merged
merged 2 commits into from
Nov 22, 2024
Merged

chore: seding chain id and remote #142

merged 2 commits into from
Nov 22, 2024

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Nov 21, 2024

  • seding chain id and remote

@iuricmp iuricmp requested a review from jefft0 November 21, 2024 20:08
@jefft0
Copy link
Contributor

jefft0 commented Nov 22, 2024

For the tosignin message, need to add client_name here:

    url.searchParams.append('client_name', 'dSocial');

Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators. Also tested on iOS where the remote is the local gnodev. See my comment to add client_name for tosignin #142 (comment) .

@iuricmp iuricmp merged commit 8a5a34f into main Nov 22, 2024
1 check passed
@iuricmp iuricmp deleted the chore/chain-id-remote branch November 22, 2024 13:17
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 1.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants