Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] : Add the automatic installation of gnopls #3

Open
DIGIX666 opened this issue Feb 4, 2025 · 5 comments
Open

[Dev] : Add the automatic installation of gnopls #3

DIGIX666 opened this issue Feb 4, 2025 · 5 comments
Assignees

Comments

@DIGIX666
Copy link
Collaborator

DIGIX666 commented Feb 4, 2025

Add the gnopls installation function if the user does not have the binary on his laptop

Note for me -> check this PR

@DIGIX666 DIGIX666 moved this to Todo in Théo Project Board Feb 4, 2025
@DIGIX666 DIGIX666 self-assigned this Feb 4, 2025
@DIGIX666
Copy link
Collaborator Author

DIGIX666 commented Feb 4, 2025

@DIGIX666 DIGIX666 moved this from Todo to Done in Théo Project Board Feb 4, 2025
@DIGIX666 DIGIX666 closed this as completed by moving to Done in Théo Project Board Feb 4, 2025
@DIGIX666
Copy link
Collaborator Author

DIGIX666 commented Feb 4, 2025

resolved

@zivkovicmilos When you have time, could you try to tell me if the extension works in your Goland IDE and if gnopls is installed.

Necessary: uninstall gnopls before adding the extension.

it works for me

@DIGIX666 DIGIX666 reopened this Feb 4, 2025
@angelozerr
Copy link

angelozerr commented Feb 11, 2025

@DIGIX666 for the moment you can do that redhat-developer/lsp4ij#751 (comment) but I have the intention to provide an API to do that with redhat-developer/lsp4ij#833

LSP API provides the capability to customize a lof of LSP features, I suggest that you read https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPApi.md

@DIGIX666 DIGIX666 moved this from Done to In Progress in Théo Project Board Feb 11, 2025
@DIGIX666
Copy link
Collaborator Author

My code works, it installs gnopls if the user doesn't have the binary on it (GnoLanguageServer)

But you think it's poorly implemented @angelozerr ?

@angelozerr
Copy link

The main problem that I see is that if install takes some times, language server startup will take some times and features like codelens, folding, inlay hint will be blocked by this time and could freeze the ide.

More you have no visibility about installation status.

My pr provides the capability to disable the start of the language server if installation must be occured or if installation is running.

It shows the install status in a backround task and start the language server when install is done correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants