Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail_head_slice is unsound #76

Open
gnzlbg opened this issue Oct 28, 2019 · 0 comments
Open

tail_head_slice is unsound #76

gnzlbg opened this issue Oct 28, 2019 · 0 comments

Comments

@gnzlbg
Copy link
Owner

gnzlbg commented Oct 28, 2019

The tail_head_slice method is unsafe, but impossible to use correctly because it returns a &[T] to uninitialized memory. It should return a &[MaybeUninit<T>].

cc @Shnatsel - while there is code using this method, I don't think there are currently any mis optimizations due to this difference (e.g. this is UB at the language spec level, but for the current toolchain, everything is fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant