fix k8s headless service miss namespace (#3407)

* feat: add namespace for initialize the registry * feat: add namespace for initialize the registry * feat: add namespace for initialize the registry * feat: add namespace for initialize the registry
go-kratos · Nov 4, 2024 · 3ecb1d6 · 3ecb1d6
1 parent 79886e4
commit 3ecb1d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/contrib/registry/kubernetes/registry.go b/contrib/registry/kubernetes/registry.go
@@ -91,8 +91,11 @@ type Registry struct {
 }
 
 // NewRegistry is used to initialize the Registry
-func NewRegistry(clientSet *kubernetes.Clientset) *Registry {
-	informerFactory := informers.NewSharedInformerFactory(clientSet, time.Minute*10)
+func NewRegistry(clientSet *kubernetes.Clientset, namespace string) *Registry {
+	if strings.EqualFold(namespace, "") {
+		namespace = metav1.NamespaceAll
+	}
+	informerFactory := informers.NewSharedInformerFactoryWithOptions(clientSet, time.Minute*10, informers.WithNamespace(namespace))
 	podInformer := informerFactory.Core().V1().Pods().Informer()
 	podLister := informerFactory.Core().V1().Pods().Lister()
 	return &Registry{

diff --git a/contrib/registry/kubernetes/registry_test.go b/contrib/registry/kubernetes/registry_test.go
@@ -100,7 +100,7 @@ func TestRegistry(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	r := NewRegistry(clientSet)
+	r := NewRegistry(clientSet, currentNamespace)
 	r.Start()
 
 	svrHello := &registry.ServiceInstance{