From 3ecb1d62dcd46b3412c86f3036b0b2684652eb2b Mon Sep 17 00:00:00 2001 From: dagehuifei <145953245+dagehuifei@users.noreply.github.com> Date: Mon, 4 Nov 2024 11:02:38 +0800 Subject: [PATCH] fix k8s headless service miss namespace (#3407) * feat: add namespace for initialize the registry * feat: add namespace for initialize the registry * feat: add namespace for initialize the registry * feat: add namespace for initialize the registry --- contrib/registry/kubernetes/registry.go | 7 +++++-- contrib/registry/kubernetes/registry_test.go | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/contrib/registry/kubernetes/registry.go b/contrib/registry/kubernetes/registry.go index 7379abf389b..f01c5e574d9 100644 --- a/contrib/registry/kubernetes/registry.go +++ b/contrib/registry/kubernetes/registry.go @@ -91,8 +91,11 @@ type Registry struct { } // NewRegistry is used to initialize the Registry -func NewRegistry(clientSet *kubernetes.Clientset) *Registry { - informerFactory := informers.NewSharedInformerFactory(clientSet, time.Minute*10) +func NewRegistry(clientSet *kubernetes.Clientset, namespace string) *Registry { + if strings.EqualFold(namespace, "") { + namespace = metav1.NamespaceAll + } + informerFactory := informers.NewSharedInformerFactoryWithOptions(clientSet, time.Minute*10, informers.WithNamespace(namespace)) podInformer := informerFactory.Core().V1().Pods().Informer() podLister := informerFactory.Core().V1().Pods().Lister() return &Registry{ diff --git a/contrib/registry/kubernetes/registry_test.go b/contrib/registry/kubernetes/registry_test.go index 1ba71fed185..bebb39e8290 100644 --- a/contrib/registry/kubernetes/registry_test.go +++ b/contrib/registry/kubernetes/registry_test.go @@ -100,7 +100,7 @@ func TestRegistry(t *testing.T) { t.Fatal(err) } - r := NewRegistry(clientSet) + r := NewRegistry(clientSet, currentNamespace) r.Start() svrHello := ®istry.ServiceInstance{